feat(sub v3): PAYG card #101203
Open
feat(sub v3): PAYG card #101203
+714
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
JonasBa
reviewed
Oct 9, 2025
Comment on lines
+33
to
+34
| <Flex direction="column" gap="xl"> | ||
| <Heading as="h2"> |
JonasBa
reviewed
Oct 9, 2025
Comment on lines
+190
to
+204
| const Currency = styled('div')` | ||
| &::before { | ||
| position: absolute; | ||
| padding: 9px ${p => p.theme.space.xl} ${p => p.theme.space.md}; | ||
| content: '$'; | ||
| color: ${p => p.theme.subText}; | ||
| font-size: ${p => p.theme.fontSize.sm}; | ||
| font-weight: bold; | ||
| } | ||
| `; | ||
|
|
||
| const StyledInput = styled(Input)` | ||
| padding-left: ${p => p.theme.space['3xl']}; | ||
| font-weight: bold; | ||
| `; |
There was a problem hiding this comment.
I won't comment on the rest, but seeing a 500 line frontend PR with only two styled components is very nice to see :)
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| } | ||
|
|
||
| return onDemandBudgets.onDemandSpendUsed ?? 0; | ||
| } |
There was a problem hiding this comment.
Bug: Undefined Check Missing in getTotalSpend
In getTotalSpend, when budgetMode is PER_CATEGORY, Object.values(onDemandBudgets.usedSpends) is called without checking if usedSpends is defined, which can lead to a runtime error.
| onClick={() => { | ||
| if (isLegacy) { | ||
| openOnDemandBudgetEditModal({organization, subscription, theme}); | ||
| } else { |
There was a problem hiding this comment.
Bug: Unexpected Theme Parameter Causes Errors
The openOnDemandBudgetEditModal function is called with a theme parameter that its definition does not expect. This mismatch could lead to runtime errors.
scttcper
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modern
legacy